Unify transition also in external samplers #2030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 71c8097.
Pull Request Test Coverage Report for Build 5494388244
💛 - Coveralls |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #2030 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 21 22 +1
Lines 1419 1444 +25
======================================
- Misses 1419 1444 +25
☔ View full report in Codecov by Sentry. |
JaimeRZP
requested review from
torfjelde and
devmotion
and removed request for
torfjelde
devmotion
reviewed
Jul 6, 2023
devmotion
reviewed
Jul 7, 2023
devmotion
reviewed
Jul 7, 2023
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
|
EDIT: Nvm, I completely forgot that was already done 🤦 |
devmotion
reviewed
Jul 7, 2023
|
Nice improvements -- thanks, @JaimeRZP! |
devmotion
reviewed
Jul 10, 2023
| @@ -39,7 +39,6 @@ Tracker = "9f7883ad-71c0-57eb-9f7f-b5c9e6d3789c" | |||
| [compat] | |||
| AbstractMCMC = "4" | |||
| AdvancedHMC = "0.3.0, 0.4" | |||
| AdvancedMH = "0.6.8, 0.7" | |||
There was a problem hiding this comment.
Just noticed now, seems this was removed by accident?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer need
TuringTransition