New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-organise tests. #2058
Re-organise tests. #2058
Conversation
import LogDensityProblemsAD | ||
|
||
|
||
# |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we feel this is more readable than what we did before?
As in, why don't we just keep the separate files but include all of them in a single file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect that anyone ever reads them.
I prefer to keep these code in fewer files since it often contains a collection of tiny utility sets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm uncertain if this is an issue of Turing.jl or rather an issue of "standard Julia workflow".
What I usually do is that I take this "header" for the runtests.jl
, paste it into a setup.jl
file (similar to what you've done, but using include
instead), and then use this is a setup-file for my testruns. I then use a custom script which re-runs the files I've specified whenever changes are made to either the package or the tests themselves (script: https://gist.github.com/torfjelde/62c1281d5fc486d3a404e5de6cf285d4). You might find this useful:)
@torfjelde Your workflow is much better! However, it is helpful to introduce a simple way to achieve a similar objective. Hence this PR. |
Fair! But do we need to also remove all the files in the process? As in, why not just use |
Pull Request Test Coverage Report for Build 5719263514
💛 - Coveralls |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #2058 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 21 21
Lines 1447 1447
======================================
Misses 1447 1447
☔ View full report in Codecov by Sentry. |
Closed in favour of #2179 |
This PR makes it easy to run each test file individually locally:
This PR doesn't contain any functionality changes.