Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename a few folders for clarity #2073

Merged
merged 7 commits into from
Sep 4, 2023
Merged

rename a few folders for clarity #2073

merged 7 commits into from
Sep 4, 2023

Conversation

yebai
Copy link
Member

@yebai yebai commented Sep 1, 2023

Moving some files around for clarity -- there are no functionality changes.

  • Inference --> mcmc
  • move contrib/inference/sghmc.jl to mcmc/sghmc.jl
  • modes --> optimisation
  • variational -- no change.
  • removed empty AdvancedSMCExtentions.jl test file

* Moved some files.

* Merge branch 'hg/reorg-algorithms' into hg/reorg

* Merge branch 'hg/reorg-algorithms' into hg/reorg

* remove empty test file
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

Pull Request Test Coverage Report for Build 6059632261

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Totals Coverage Status
Change from base Build 6027623645: 0.0%
Covered Lines: 0
Relevant Lines: 1492

💛 - Coveralls

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (9423562) 0.00% compared to head (d1f3222) 0.00%.
Report is 1 commits behind head on master.

❗ Current head d1f3222 differs from pull request most recent head 27b0280. Consider uploading reports for the commit 27b0280 to get more accurate results

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2073   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files          22      22           
  Lines        1492    1492           
======================================
  Misses       1492    1492           
Files Changed Coverage Δ
src/Turing.jl 0.00% <ø> (ø)
src/mcmc/Inference.jl 0.00% <ø> (ø)
src/mcmc/abstractmcmc.jl 0.00% <ø> (ø)
src/mcmc/emcee.jl 0.00% <ø> (ø)
src/mcmc/ess.jl 0.00% <ø> (ø)
src/mcmc/gibbs.jl 0.00% <ø> (ø)
src/mcmc/gibbs_conditional.jl 0.00% <ø> (ø)
src/mcmc/hmc.jl 0.00% <ø> (ø)
src/mcmc/is.jl 0.00% <ø> (ø)
src/mcmc/mh.jl 0.00% <ø> (ø)
... and 3 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@sunxd3 sunxd3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@torfjelde
Copy link
Member

Happy with this, but let's wait until the currently open major PRs have been merged, e.g. #2071, to avoid any strange conflicts?

@yebai yebai merged commit c0c8130 into master Sep 4, 2023
11 checks passed
@yebai yebai deleted the hg/reorg-algorithms branch September 4, 2023 19:44
@torfjelde
Copy link
Member

Crap. We forgot to change the module names, so things are honestly quite confusing now, e.g. folder names do not match the directories, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants