Fix for CI #2098
Merged
Fix for CI #2098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The issue with DynamicHMC.jl might have gotten fixed by mcabbott/LazyStack.jl#18 (my love for @devmotion is not describable in words) |
sunxd3
approved these changes
Oct 6, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2098 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 21 21
Lines 1451 1451
======================================
Misses 1451 1451
☔ View full report in Codecov by Sentry. |
|
thanks @sunxd3 and @torfjelde! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've added some new models to
DynamicPPL.TestUtils.DEMO_MODELSat some point, and these are also examples where optimization might terminate early because of insane values (as noted before, this is because the parameters include variances for each data point, hence, when performing MLE, these should be 0).