Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failure under brand new 2017.07 with zef #5

Closed
Altreus opened this issue Aug 2, 2017 · 10 comments
Closed

Test failure under brand new 2017.07 with zef #5

Altreus opened this issue Aug 2, 2017 · 10 comments

Comments

@Altreus
Copy link

Altreus commented Aug 2, 2017

Here's a whole bunch of output.

altreus@isaac ~/src/zef $ zef install Text::CSV
===> Searching for: Text::CSV
===> Searching for missing dependencies: Slang::Tuxic, Test::META
===> Searching for missing dependencies: META6
===> Searching for missing dependencies: JSON::Class
===> Searching for missing dependencies: JSON::Marshal, JSON::Unmarshal
===> Searching for missing dependencies: JSON::Name
===> Testing: Slang::Tuxic:ver('0.0.1'):auth('github:FROGGS')
===> Testing [OK] for Slang::Tuxic:ver('0.0.1'):auth('github:FROGGS')
===> Testing: JSON::Name:ver('0.0.2'):auth('github:jonathanstowe')
===> Testing [OK] for JSON::Name:ver('0.0.2'):auth('github:jonathanstowe')
===> Testing: JSON::Marshal:ver('0.0.13'):auth('github:jonathanstowe')
===> Testing [OK] for JSON::Marshal:ver('0.0.13'):auth('github:jonathanstowe')
===> Testing: JSON::Unmarshal:ver('0.08')
===> Testing [OK] for JSON::Unmarshal:ver('0.08')
===> Testing: JSON::Class:ver('0.0.9'):auth('github:jonathanstowe')
===> Testing [OK] for JSON::Class:ver('0.0.9'):auth('github:jonathanstowe')
===> Testing: META6:ver('0.0.16'):auth('github:jonathanstowe')
===> Testing [OK] for META6:ver('0.0.16'):auth('github:jonathanstowe')
===> Testing: Test::META:ver('0.0.10'):auth('github:jonathanstowe')
# the following may make some diagnostics from the module itself
===> Testing [OK] for Test::META:ver('0.0.10'):auth('github:jonathanstowe')
===> Testing: Text::CSV:ver('0.008'):auth('github:Tux')
Invocant of method 'Bridge' must be an object instance of type 'Int', not a type object of type 'Bool'.  Did you forget a '.new'?
  in method ready at /home/altreus/.zef/store/CSV.git/06a450d811b7bd5e9b9cb714e2888f1816fbdd91/lib/Text/CSV.pm (Text::CSV) line 875
  in method combine at /home/altreus/.zef/store/CSV.git/06a450d811b7bd5e9b9cb714e2888f1816fbdd91/lib/Text/CSV.pm (Text::CSV) line 958
  in method combine at /home/altreus/.zef/store/CSV.git/06a450d811b7bd5e9b9cb714e2888f1816fbdd91/lib/Text/CSV.pm (Text::CSV) line 942
  in block <unit> at t/10_base.t line 41

Invocant of method 'Bridge' must be an object instance of type 'Int', not a type object of type 'Bool'.  Did you forget a '.new'?
  in method ready at /home/altreus/.zef/store/CSV.git/06a450d811b7bd5e9b9cb714e2888f1816fbdd91/lib/Text/CSV.pm (Text::CSV) line 875
  in sub parse_done at /home/altreus/.zef/store/CSV.git/06a450d811b7bd5e9b9cb714e2888f1816fbdd91/lib/Text/CSV.pm (Text::CSV) line 1015
  in method parse at /home/altreus/.zef/store/CSV.git/06a450d811b7bd5e9b9cb714e2888f1816fbdd91/lib/Text/CSV.pm (Text::CSV) line 1316
  in block <unit> at t/12_acc.t line 180

Invocant of method 'Bridge' must be an object instance of type 'Int', not a type object of type 'Bool'.  Did you forget a '.new'?
  in method ready at /home/altreus/.zef/store/CSV.git/06a450d811b7bd5e9b9cb714e2888f1816fbdd91/lib/Text/CSV.pm (Text::CSV) line 875
  in sub parse_done at /home/altreus/.zef/store/CSV.git/06a450d811b7bd5e9b9cb714e2888f1816fbdd91/lib/Text/CSV.pm (Text::CSV) line 1015
  in method parse at /home/altreus/.zef/store/CSV.git/06a450d811b7bd5e9b9cb714e2888f1816fbdd91/lib/Text/CSV.pm (Text::CSV) line 1316
  in block <unit> at t/15_flags.t line 69

Invocant of method 'Bridge' must be an object instance of type 'Int', not a type object of type 'Bool'.  Did you forget a '.new'?
  in method ready at /home/altreus/.zef/store/CSV.git/06a450d811b7bd5e9b9cb714e2888f1816fbdd91/lib/Text/CSV.pm (Text::CSV) line 875
  in method combine at /home/altreus/.zef/store/CSV.git/06a450d811b7bd5e9b9cb714e2888f1816fbdd91/lib/Text/CSV.pm (Text::CSV) line 958
  in method print at /home/altreus/.zef/store/CSV.git/06a450d811b7bd5e9b9cb714e2888f1816fbdd91/lib/Text/CSV.pm (Text::CSV) line 1507
  in method print at /home/altreus/.zef/store/CSV.git/06a450d811b7bd5e9b9cb714e2888f1816fbdd91/lib/Text/CSV.pm (Text::CSV) line 1525
  in block <unit> at t/20_file.t line 14

TODO: EOL = "!", RS = ""
      "1,2,3!4,5,6!"
  --> ["1"]
TODO: EOL = "!!", RS = ""
      "1,2,3!!4,5,6!!"
  --> ["1"]
TODO: EOL = "!!", RS = "!"
      "1,2,3!!4,5,6!!"
  --> ["1", "2", "3!"]
TODO: EOL = "!\n", RS = ""
      "1,2,3!\n4,5,6!\n"
  --> ["1"]
TODO: EOL = "!\n", RS = "!"
      "1,2,3!\n4,5,6!\n"
  --> ["1", "2", "3!"]
TODO: EOL = "!\n!", RS = ""
      "1,2,3!\n!4,5,6!\n!"
  --> ["1"]
TODO: EOL = "!\n!", RS = "\n"
      "1,2,3!\n!4,5,6!\n!"
  --> ["1", "2", "3!\n"]
TODO: EOL = "!\n!", RS = "!"
      "1,2,3!\n!4,5,6!\n!"
  --> ["1", "2", "3!"]
TODO: EOL = "!\n!", RS = "!\n"
      "1,2,3!\n!4,5,6!\n!"
  --> ["1", "2", "3!\n"]
TODO: EOL = "!!!!!!!!", RS = ""
      "1,2,3!!!!!!!!4,5,6!!!!!!!!"
  --> ["1"]
TODO: EOL = "!!!!!!!!", RS = "!"
      "1,2,3!!!!!!!!4,5,6!!!!!!!!"
  --> ["1", "2", "3!"]
TODO: EOL = "!!!!!!!!!!", RS = ""
      "1,2,3!!!!!!!!!!4,5,6!!!!!!!!!!"
  --> ["1"]
TODO: EOL = "!!!!!!!!!!", RS = "!"
      "1,2,3!!!!!!!!!!4,5,6!!!!!!!!!!"
  --> ["1", "2", "3!"]
TODO: EOL = "\n!!!!!\n!!!!!", RS = ""
      "1,2,3\n!!!!!\n!!!!!4,5,6\n!!!!!\n!!!!!"
  --> ["1"]
TODO: EOL = "\n!!!!!\n!!!!!", RS = "\n"
      "1,2,3\n!!!!!\n!!!!!4,5,6\n!!!!!\n!!!!!"
  --> ["1", "2", "3\n"]
TODO: EOL = "\n!!!!!\n!!!!!", RS = "!"
      "1,2,3\n!!!!!\n!!!!!4,5,6\n!!!!!\n!!!!!"
  --> ["1", "2", "3\n!"]
TODO: EOL = "\n!!!!!\n!!!!!", RS = "!\n"
      "1,2,3\n!!!!!\n!!!!!4,5,6\n!!!!!\n!!!!!"
  --> ["1", "2", "3\n!!!!!\n"]
TODO: EOL = "\n!!!!!\n!!!!!", RS = "\n!"
      "1,2,3\n!!!!!\n!!!!!4,5,6\n!!!!!\n!!!!!"
  --> ["1", "2", "3\n!"]
TODO: EOL = "\n!!!!!\n!!!!!", RS = "!\n!"
      "1,2,3\n!!!!!\n!!!!!4,5,6\n!!!!!\n!!!!!"
  --> ["1", "2", "3\n!!!!!\n!"]
TODO: EOL = "!!!!!\n!!!!!\n", RS = ""
      "1,2,3!!!!!\n!!!!!\n4,5,6!!!!!\n!!!!!\n"
  --> ["1"]
TODO: EOL = "!!!!!\n!!!!!\n", RS = "\n"
      "1,2,3!!!!!\n!!!!!\n4,5,6!!!!!\n!!!!!\n"
  --> ["1", "2", "3!!!!!\n"]
TODO: EOL = "!!!!!\n!!!!!\n", RS = "!"
      "1,2,3!!!!!\n!!!!!\n4,5,6!!!!!\n!!!!!\n"
  --> ["1", "2", "3!"]
TODO: EOL = "!!!!!\n!!!!!\n", RS = "!\n"
      "1,2,3!!!!!\n!!!!!\n4,5,6!!!!!\n!!!!!\n"
  --> ["1", "2", "3!!!!!\n"]
TODO: EOL = "!!!!!\n!!!!!\n", RS = "\n!"
      "1,2,3!!!!!\n!!!!!\n4,5,6!!!!!\n!!!!!\n"
  --> ["1", "2", "3!!!!!\n!"]
TODO: EOL = "!!!!!\n!!!!!\n", RS = "!\n!"
      "1,2,3!!!!!\n!!!!!\n4,5,6!!!!!\n!!!!!\n"
  --> ["1", "2", "3!!!!!\n!"]
TODO: EOL = "\%^+_\n\0!X**", RS = ""
      "1,2,3\%^+_\n\0!X**4,5,6\%^+_\n\0!X**"
  --> ["1"]
TODO: EOL = "\%^+_\n\0!X**", RS = "\n"
      "1,2,3\%^+_\n\0!X**4,5,6\%^+_\n\0!X**"
  --> ["1", "2", "3\%^+_\n"]
TODO: EOL = "\%^+_\n\0!X**", RS = "!"
      "1,2,3\%^+_\n\0!X**4,5,6\%^+_\n\0!X**"
  --> ["1", "2", "3\%^+_\n\0!"]
TODO: EOL = "\r\n", RS = ""
      "1,2,3\r\n4,5,6\r\n"
  --> ["1"]
TODO: EOL = "\r", RS = ""
      "1,2,3\r4,5,6\r"
  --> ["1"]

# Failed test 'Second field is not quoted'
# at t/50_utf8.t line 58
# expected: 'False'
#      got: (Bool)

# Failed test 'Second field is not binary'
# at t/50_utf8.t line 60
# expected: 'False'
#      got: (Bool)

# Failed test 'Second field is not quoted'
# at t/50_utf8.t line 63
# expected: 'False'
#      got: (Bool)

# Failed test 'Second field is not binary'
# at t/50_utf8.t line 65
# expected: 'False'
#      got: (Bool)

# Failed test 'not binary'
# at t/50_utf8.t line 99
# expected: 'False'
#      got: (Bool)

# Failed test 'not binary'
# at t/50_utf8.t line 107
# expected: 'False'
#      got: (Bool)

# Failed test 'not utf8'
# at t/50_utf8.t line 109
# expected: 'False'
#      got: (Bool)
# Looks like you failed 7 tests of 93

# Failed test 'Is field 2 quoted?'
# at t/65_allow.t line 198
# expected: 'False'
#      got: (Bool)
# Looks like you failed 1 test of 1022
Invocant of method 'Bridge' must be an object instance of type 'Int', not a type object of type 'Bool'.  Did you forget a '.new'?
  in method ready at /home/altreus/.zef/store/CSV.git/06a450d811b7bd5e9b9cb714e2888f1816fbdd91/lib/Text/CSV.pm (Text::CSV) line 875
  in sub parse_done at /home/altreus/.zef/store/CSV.git/06a450d811b7bd5e9b9cb714e2888f1816fbdd91/lib/Text/CSV.pm (Text::CSV) line 1015
  in method parse at /home/altreus/.zef/store/CSV.git/06a450d811b7bd5e9b9cb714e2888f1816fbdd91/lib/Text/CSV.pm (Text::CSV) line 1316
  in sub parse_err at t/80_diag.t line 29
  in block <unit> at t/80_diag.t line 58

===> Testing [FAIL]: Text::CSV:ver('0.008'):auth('github:Tux')
Aborting due to test failure: Text::CSV:ver('0.008'):auth('github:Tux') (use --force-test to override)
  in code  at /home/altreus/perl6/rakudo-star-2017.07/share/perl6/site/sources/1C5B2A3EA861108A89345CD9B974CE9BF1FEE32F (Zef::Client) line 373
  in method test at /home/altreus/perl6/rakudo-star-2017.07/share/perl6/site/sources/1C5B2A3EA861108A89345CD9B974CE9BF1FEE32F (Zef::Client) line 351
  in code  at /home/altreus/perl6/rakudo-star-2017.07/share/perl6/site/sources/1C5B2A3EA861108A89345CD9B974CE9BF1FEE32F (Zef::Client) line 528
  in sub  at /home/altreus/perl6/rakudo-star-2017.07/share/perl6/site/sources/1C5B2A3EA861108A89345CD9B974CE9BF1FEE32F (Zef::Client) line 525
  in method install at /home/altreus/perl6/rakudo-star-2017.07/share/perl6/site/sources/1C5B2A3EA861108A89345CD9B974CE9BF1FEE32F (Zef::Client) line 631
  in sub MAIN at /home/altreus/perl6/rakudo-star-2017.07/share/perl6/site/sources/8CF719A0E6E0BBDC883C69273F5806F53CE89B08 (Zef::CLI) line 152
  in block <unit> at /home/altreus/perl6/rakudo-star-2017.07/share/perl6/site/resources/9F7A8B63F1D79866260D0A0CD3594BA28A8D75BA line 1
  in sub MAIN at /home/altreus/perl6/rakudo-star-2017.07/share/perl6/site/bin/zef line 2
  in block <unit> at /home/altreus/perl6/rakudo-star-2017.07/share/perl6/site/bin/zef line 2

Will swap thanks for info :-)

@nxadm
Copy link

nxadm commented Aug 2, 2017

I have the same error on 2017.06. Altreus is on 2017.07.

@Tux
Copy link
Owner

Tux commented Aug 2, 2017

It is likely that part of the output is due to some problem in zef that is currently under investigation
The EOL lines are part of the test suite and are waiting for changes and personal effort in trying to make that possible (or remove the functionality)
Due to the problems with zef (to which I have no influence), the only failing test should be 99_meta.t

This is Rakudo version 2017.07-116-g01dbd874e built on MoarVM version 2017.07-266-ged84a632
implementing Perl 6.c.

@nxadm
Copy link

nxadm commented Aug 2, 2017

Hi Tux,

On #perl6 this commit was suggested as the cultpit: 06a450d

It works on blead but not on released rakudo's.

C.

@lizmat
Copy link
Collaborator

lizmat commented Aug 2, 2017 via email

@Tux
Copy link
Owner

Tux commented Aug 2, 2017

That is likely/possible. Let me try to explain
Text::CSV is (also) used as canary in the coalmine to spot performance issues in perl6 development and adds 22347 tests that touch edge cases.
As of October 2014, I keep a track record of how perl6 and CSV parsing compared to perl5 and other languages. See http://tux.nl/Talks/CSV6/speed4.html and http://tux.nl/Talks/CSV6/speed5.html
In order to try to squeeze all possible speed gains out of CSV, hoping to get faster and faster, Liz and I follow the perl6 development on the day/hour/minute and try to see if implemented changes in the language itself show effect on the parsing speed. The risk is - of course - that we break installing Text::CSV on old(er) versions. The change you refer to is something that made both of us happy. Changes like that have measurable impact.
So, sorry if that breaks installing on not yet released perl6.
You can install commit 06a450d

@Tux
Copy link
Owner

Tux commented Feb 27, 2018

@lizmat can we require a newer perl6 by now and move on to optimized code again?

@Tux
Copy link
Owner

Tux commented Mar 27, 2018

@lizmat ^^^^^

@lizmat
Copy link
Collaborator

lizmat commented Mar 27, 2018 via email

@Tux
Copy link
Owner

Tux commented Mar 27, 2018

I am not aiming at any dated version, but at a released stable version from where we can re-add the removed optimisations and start looking at BUILD

@JJ
Copy link
Collaborator

JJ commented Jun 25, 2020

Do we still need to address this one? It's working now...

@Tux Tux closed this as completed Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants