Fix already decoded BOM in headers

CSV_XS.pm

@@ -26,7 +26,7 @@ use DynaLoader ();
 use Carp;
 
 use vars   qw( $VERSION @ISA @EXPORT_OK );
-$VERSION   = "1.30";
+$VERSION   = "1.31";
 @ISA       = qw( DynaLoader Exporter );
 @EXPORT_OK = qw( csv );
 bootstrap Text::CSV_XS $VERSION;
@@ -812,6 +812,7 @@ sub header {
 	elsif ($hdr =~ s/^\x0e\xfe\xff//)     { $enc = "scsu"       }
 	elsif ($hdr =~ s/^\xfb\xee\x28//)     { $enc = "bocu-1"     }
 	elsif ($hdr =~ s/^\x84\x31\x95\x33//) { $enc = "gb-18030"   }
+	elsif ($hdr =~ s/^\x{feff}//)         { $enc = ""           }
 
 	if ($enc) {
 	    if ($enc =~ m/([13]).le$/) {

ChangeLog

@@ -1,3 +1,6 @@
+1.31	- 2017-06-09, H.Merijn Brand
+    * Fix already decoded BOM in headers
+
 1.30	- 2017-06-08, H.Merijn Brand
     * Add csv (..., out => ...) syntax examples (issue 7)
     * Disable escape_null for undefined escape_char

sandbox/pm-1192242.csv

@@ -0,0 +1,2 @@
+"Volume.label","Volume.serialno","Volume.vtype","Volume.netname","Volume.filesystem","Path.name",,"Thumbnail.checksum","Thumbnail.width","Thumbnail.height","Thumbnail.horiz_res","Thumbnail.vert_res","Thumbnail.colortype","Thumbnail.colordepth","Thumbnail.gamma","Thumbnail.thumbnail_width","Thumbnail.thumbnail_height","Thumbnail.thumbnail_type","Thumbnail.thumbnail_size","Thumbnail.name","Thumbnail.metric1","Keywords.pkeywords",
+PCD0138,,4037894171,5,\\ddb\r$,CDFS,PHOTO_CD\IMAGES,1,0,0,"1996-09-30T21:38:57","2002-10-12T00:29:25",3368960,2147483648,512,768,0,0,0,24,0,68,100,518,336,IMG0002.PCD,m000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000,b00000000000000000000000000000000,,0,";",lose

sandbox/pm-1192242.pl

@@ -0,0 +1,26 @@
+#!/pro/bin/perl
+
+# Read the export from Thumbs Plus including keywords from filename given.
+
+use 5.18.2;	# 5.12 or later to get "unicode_strings" feature
+use utf8;	# so literals and identifiers can be in UTF-8
+use warnings  qw(FATAL utf8);    # fatalize encoding glitches
+use Data::Peek;	# debug
+use Text::CSV;
+
+my $csv = Text::CSV->new ({ binary => 1, auto_diag => 1 });
+
+my $fn = "pm-1192242.csv";
+-d "sandbox" and substr $fn, 0, 0, "sandbox/";
+say $fn;
+open my $fh, "<", $fn or die "$fn: $!\n";
+#open my $fh, "<:encoding(utf-8)", $fn or die "$fn: $!\n";
+say "Point a";
+
+# Returns "the instance" -- of what?  Do I care?
+my @hdr = $csv->header ($fh, {
+    munge_column_names => sub { state $i; $_ || "nothing.".$i++ }});
+say "Point b";
+
+DDumper { csv => $csv, hdr => \@hdr };
+say for @hdr;