Fix the number of tests to skip, which varies depending on the value of $enc #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Which is kinda weird, as I do test with perl-5.8.4 before releasing. |
|
Thanks. There are also five pass reports from Nigel Horne (http://matrix.cpantesters.org/?dist=Text-CSV_XS%201.38;perl=5.8.4;reports=1). So I wondered when I got the report, and found the mismatch of the skip count. |
|
Just for the record. Encode::Alias has a bad regex in all versions up to and including Encode-2.01. This caused the fallout and surfaced my miscount. Thanks for the fix. I merged and then added comments and a note in the ChangeLog |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've got a report from Andreas that the latest Text::CSV was broken under Perl 5.8.4 because of the incorrect test plan (cf http://www.cpantesters.org/cpan/report/e65245fc-0e09-11e9-99de-cfe2e2691208). It seems that one of the numbers of tests to skip in t/85_util.t is wrong (9 or 10, depending on the vlaue of $enc), and so is the whole test plan because of that.