More fixes for POC rename symbol #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* elixir-lsp#673 fix hover bug for * use function_exported to check module be loaded Change-Id: I8e3c3cde067a7d3313422c0a94f4c4a464bd37de * remove rescue and use if instead of nested cond Change-Id: Ia85056971d7333df5d6a7cf6d3a6bd21c87635eb Co-authored-by: zhuzhenfeng.code <zhuzhenfeng.code@bytedance.com>
compatibility improvement: only return variable type and pagination properties when supported by client run evaluate in a stacktrace frame if specified
…r-lsp#675) * add support for terminateThreads request * add support for pause * format
…nto elixir_sense (elixir-lsp#677) * add utility functions for utf8-utf16 conversions * fix numerous cases of incorrect utf16 positions
…lixir-lsp#678) * remove not supported SetExceptionBreakpoints request handler Clients should only call this request if the capability ‘exceptionBreakpointFilters’ returns one or more filters. No way to implement it via :int module * implement function breakpoints * test erlang breakpoints * fix small memory leak when unsetting last breakpoint in file * add more breakpoint tests * make tests more synchronous * add function breakpoints tests * interpret modules * extract and test mfa parsing * run formatter * Update readme * cleanup * extract and test erlang binding processing fix some isses when var is usend more than 10 times add explicite ordering by variable instance discard underscored variables * breakpoint conditions support added do not warn when setting already set breakpoint * update readme * log when expression crashes * add support for conditional function breakpoints * update readme * add support for breakpoint hit condition * readme updated * implement log message * readme updated * add support for terminateThreads request * add support for pause * make continue, next, stepIn, stepout requests conform to DAP 1.51 Fixes elixir-lsp#669 reworks fixes for elixir-lsp#455 * cleanup :int workaround * tests wip * format
* add support for hover and clipboard eval in debugger * use empty string
* fix typo * warn about not supported client options * Add support for debugger completions
…sp#681) * delete duplicated capability * add process messages as debugger variable scope * improve display of keyword variables * add process info as debugger variable scope
…ir-lsp#684) * Suggest an appropriate module name when auto-completing the 'defmodule' snippet * use processed file_path instead of raw file:// uri for determining appropriate module_names * add umbrella_app test to guard against future regressions * special case common Phoenix folders when suggesting module names * fix broken test Some plugin or setting in my editor trimmed extra spaces from the lines but in this case it cause a test to break by changing the cursor position of the auto-completion trigger
* Consistent headers (getting-started section) * Fix wrong header for vscode getting-started page * Removes trailing spaces * Fixes typos
…d rebuild is necessary Fixes elixir-lsp#686
do not return negative numbers as those are forbidden by the LSP properly treat 0 as unknown position add missing handling for positions with column add missing handling for positions as ranges if file the diagnostics refer to is not open fall back to loading it from the file system do not return lines and columns if we cannot load the file Fixes elixir-lsp#695
* check if loading apps is still needed * Revert "check if loading apps is still needed" This reverts commit d03cfe5. * rename function to match what it actually do * extract diagnostic related code * extract common mix.exs code * fix tests
…Symbol provider Fixes elixir-lsp#700
Disable dialyzer and continue Fixes elixir-lsp#540
Path.wildcard is not working on umbrella level
Right now, this change is a no-op, but if and when this change elixir-lsp/elixir_sense#165 lands, this will quiet elixir_sense's logging in the prod environment, which will prevent logspam in lsp buffers when elixir_sense encounters invalid code.
position should trim to the end of the line
This triggers race conditions in elixir compiler Fixes elixir-lsp#763
…ixir-lsp#768) - so, this behavior wasn't working for me in vs-code, so I hopped into the repo to write a failing test, but the test passed right away (🤔) and I'm now seeing the behavior _sometimes_ work and sometimes not in vs-code - conclusion is that the issue is likely in the vs-code extension, but I figured I'd submit a PR with the regression test if it's desired
|
@Tuxified I think this is pretty much ready, though recent changes to the elixir sense dependency seem to have broken things :( I need to take a deeper look into that but let me know if you have any suggestions. Adding the trace argument seems to fix most things, but the test for renaming a function defined in another file is now broken :( |
|
Added some test setup bits and it's all working again now 👍 Let me know if you're happy to merge this to get your PR updated, or if it would be easier for me to raise a new PR with the main repo and then I can follow up any comments too. I'm happy either way :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few more fixes on this:
nilfor the version, which seems to have fixed the[coc.nvim] Error on applyEdits: Error: file:///.... changed before apply editissue I was having beforeEnum.uniqon the list of changes to fix thatStuff I think still needs doing:
I've now raised a PR for this on the elixir sense repo - elixir-lsp/elixir_sense#172 - it has been merged now
Things for follow-up PRs:
Btw do you have any guidance on testing with VS code? I mostly use Vim, but would like to test things out on VS code too. UPDATE: This seems helpful - https://dragoshmocrii.com/fix-vscode-elixirls-intellisense-for-code-imported-with-use/