Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TweakScale is failing to consistently resize the Attachment Node's sizes. #238

Closed
Lisias opened this issue Mar 26, 2022 · 3 comments
Closed
Assignees
Labels
bug Something isn't working duplicate This issue or pull request already exists
Milestone

Comments

@Lisias
Copy link

Lisias commented Mar 26, 2022

As the title says, I just found that TweakScale is failing to resize the AttachmentNode's size when you Alt+Copy a part that have variants.

Interesting enough, once you save and reload the craft the node sizes are alright - so it's a flaw on the OnClone callback.

It also happens on KSP 1.7.3, so the 1.9.x editor's bug is not related (but it's a missing use case on KSP-Recall anyway).

@Lisias
Copy link
Author

Lisias commented May 10, 2022

And the positions too!!

Interesting enough, I found an easy workaround while checking an unrelated report, and found that changing the VARIANT to something else and then back solves the issue.

So it's really something silly I forgot to handle when handling variants….

@Lisias Lisias self-assigned this Jun 24, 2022
@Lisias Lisias added this to the 2.4.7.0 milestone Jun 24, 2022
@Lisias Lisias modified the milestones: 2.4.7.0, 2.4.7.1 Jul 8, 2022
@Lisias Lisias modified the milestones: 2.4.7.1, 2.4.6.20 Jan 24, 2023
@Lisias
Copy link
Author

Lisias commented Jan 24, 2023

Tackling down this sooner. I think #261 may had solved this by collateral effect.

@Lisias
Copy link
Author

Lisias commented Jan 24, 2023

Yep, it's fixed now. :)

@Lisias Lisias closed this as completed Jan 24, 2023
@Lisias Lisias added bug Something isn't working duplicate This issue or pull request already exists labels Jan 26, 2023
@Lisias Lisias modified the milestones: 2.4.6.20, 2.4.6.21 Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

1 participant