Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replicate the fix from https://github.com/net-lisias-ksp/AviationLights/issues/4 #313

Open
Lisias opened this issue Sep 22, 2023 · 1 comment
Assignees
Labels
bug Something isn't working enhancement New feature or request My fault I Borked on this one
Milestone

Comments

@Lisias
Copy link

Lisias commented Sep 22, 2023

Oukey,

We may have found the reason why some users report mysterious misbehaviours that I can't replicated on my rigs.

On net-lisias-ksp/AviationLights#4 , I apparently fixed one of these mysterious misbehaviours and, well, if AL could misbehave due the Update being called outside the intended Scene, then TweakScale may also.

I'm wondering if using the PartModule's OnUpdate would be a better idea, as hopefully it could handle this mess for us - or perhaps not, but I need to check first if the TweakScale's Update is being called outside the intended scenes (I'm betting it is).

@Lisias Lisias added bug Something isn't working enhancement New feature or request My fault I Borked on this one labels Sep 22, 2023
@Lisias Lisias added this to the 2.4.7.4 milestone Sep 22, 2023
@Lisias Lisias self-assigned this Sep 22, 2023
@Lisias
Copy link
Author

Lisias commented Sep 22, 2023

Labeled it as a bug, because if I'm right TweakScale would be misbehaving on these borderline situations.

Labeled also as an enhancement, as TweakScale should not had been forced to worry about this crap.

Labeled as "Not my fault" because… Well, it's not my fault! :)

@Lisias Lisias modified the milestones: 2.4.7.4, 2.4.7.5 Oct 7, 2023
@Lisias Lisias modified the milestones: 2.4.7.5, 2.4.7.7 Mar 22, 2024
@Lisias Lisias modified the milestones: 2.4.8.0, 2.4.8.x Apr 8, 2024
@Lisias Lisias modified the milestones: 2.4.8.x, 2.5.0.x May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request My fault I Borked on this one
Projects
None yet
Development

No branches or pull requests

1 participant