-
-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Truncate long strings when using pattern function #100
Conversation
Codecov Report
@@ Coverage Diff @@
## master #100 +/- ##
==========================================
- Coverage 89.75% 89.61% -0.15%
==========================================
Files 30 30
Lines 1123 1127 +4
==========================================
+ Hits 1008 1010 +2
- Misses 82 83 +1
- Partials 33 34 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful implementation, just a small change and it's perfect.
Thank you for your contribution! |
Will these changes also alleviate the size of the storage file? I didn't dig deep enough to see if the full result. |
@dchidell It should, but I've recently made some pretty decent improvements related to persistence; the result body was always persisted, but it's no longer the case. |
Released in v2.4.0 |
Fixes #98 - Unsure if this will be a desirable solution or not, but figured I would at least try and contribute a fix!