Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncate long strings when using pattern function #100

Merged
merged 5 commits into from
Mar 14, 2021
Merged

Conversation

dchidell
Copy link
Contributor

Fixes #98 - Unsure if this will be a desirable solution or not, but figured I would at least try and contribute a fix!

@codecov-io
Copy link

Codecov Report

Merging #100 (0170eb7) into master (8ec256e) will decrease coverage by 0.14%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
- Coverage   89.75%   89.61%   -0.15%     
==========================================
  Files          30       30              
  Lines        1123     1127       +4     
==========================================
+ Hits         1008     1010       +2     
- Misses         82       83       +1     
- Partials       33       34       +1     
Impacted Files Coverage Δ
core/condition.go 91.03% <50.00%> (-1.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ec256e...0170eb7. Read the comment docs.

Copy link
Owner

@TwiN TwiN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful implementation, just a small change and it's perfect.

core/condition.go Outdated Show resolved Hide resolved
core/condition_test.go Show resolved Hide resolved
@TwiN TwiN changed the title Omits verbose responses when using pattern match Truncate long strings when using pattern function Mar 14, 2021
@TwiN
Copy link
Owner

TwiN commented Mar 14, 2021

Thank you for your contribution!

@dchidell
Copy link
Contributor Author

Will these changes also alleviate the size of the storage file? I didn't dig deep enough to see if the full result.

@TwiN
Copy link
Owner

TwiN commented Mar 14, 2021

@dchidell It should, but I've recently made some pretty decent improvements related to persistence; the result body was always persisted, but it's no longer the case.

@TwiN TwiN merged commit 2c8714f into TwiN:master Mar 14, 2021
@TwiN
Copy link
Owner

TwiN commented Apr 5, 2021

Released in v2.4.0

@dchidell dchidell mentioned this pull request Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'pat' keyword causes various issues
3 participants