Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add group-specific integration key for PagerDuty #181

Merged

Conversation

achrefbensaadVPaccount
Copy link
Contributor

@achrefbensaadVPaccount achrefbensaadVPaccount commented Oct 4, 2021

What this is doing ?

Provides support for paging multiple teams based on the group selector while keeping backward compatibility to the old pagerduty configuration manifest

  • integration per team can be specified in the integrations sections in an array form.
alerting:
  pagerduty: 
    integration-key: "00000000000000000000000000000000"
    integrations:
      - integration-key: "00000000000000000000000000000000"
        group: "team"

behavior:

  • team integration have priority over the general integration (old pagerduty configuration)
  • if no team integration is provided it will defaults to the general pagerduty integration
  • if no team integration and no general integration were provided it defaults to the first team integration provided

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
alerting/provider/pagerduty/pagerduty.go Outdated Show resolved Hide resolved
alerting/provider/pagerduty/pagerduty.go Outdated Show resolved Hide resolved
@TwiN TwiN added the feature New feature or request label Oct 5, 2021
Co-authored-by: Chris <twin@twinnation.org>
Co-authored-by: Chris <twin@twinnation.org>
Co-authored-by: Chris <twin@twinnation.org>
@codecov-commenter
Copy link

Codecov Report

Merging #181 (5280b6c) into master (4a46a5a) will decrease coverage by 0.46%.
The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #181      +/-   ##
==========================================
- Coverage   87.09%   86.63%   -0.47%     
==========================================
  Files          48       48              
  Lines        2154     2177      +23     
==========================================
+ Hits         1876     1886      +10     
- Misses        186      194       +8     
- Partials       92       97       +5     
Impacted Files Coverage Δ
alerting/provider/pagerduty/pagerduty.go 91.89% <84.61%> (-4.27%) ⬇️
config/maintenance/maintenance.go 92.30% <0.00%> (-7.70%) ⬇️
client/client.go 74.00% <0.00%> (-2.93%) ⬇️
core/service.go 77.77% <0.00%> (-1.74%) ⬇️
storage/store/sql/sql.go 86.04% <0.00%> (-0.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a46a5a...5280b6c. Read the comment docs.

@TwiN TwiN changed the title Feat/pagerduty per group alerts Add group-specific integration key for PagerDuty Oct 6, 2021
@TwiN TwiN merged commit adbc2c5 into TwiN:master Oct 6, 2021
@TwiN
Copy link
Owner

TwiN commented Oct 6, 2021

@achrefbensaadVPaccount I made some adjustments in a6bc003 to support future use cases.

Namely, integrations has been renamed to overrides.

See https://github.com/TwinProduction/gatus#configuring-pagerduty-alerts

@TwiN
Copy link
Owner

TwiN commented Oct 8, 2021

Released in v3.2.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants