Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Embed files into the binary #186

Closed
wants to merge 1 commit into from

Conversation

RasmusLindroth
Copy link

This would fix #47. But will need some more work and discussion.

Work that needs to be done

  • Update the Dockerfile. I'm no good with docker even though it should be an easy fix

Things to consider

  • Should you still be able to use the "old" way? One advantage is that it lets people change the looks of gatus without re-building the binary.

Modifications besides loading files using embed instead of from a directory.

  • In spa.go it will no longer write to the client on errors. This could be fixed, but I don't think it's necessary. If it still runs even when there's an error I think it only hides the error.

  • I removed favicon.go and router.HandleFunc("/favicon.ico", FavIcon(staticFolder)).Methods("GET") because the catch all route can handle it.

@RasmusLindroth RasmusLindroth marked this pull request as draft October 15, 2021 15:11
@TwiN
Copy link
Owner

TwiN commented Aug 16, 2022

There has been too many changes since this PR was created, and it's been 10 months since this PR has been set to draft, so I'm going to close this.

Regardless, I do appreciate the effort! Thanks!

@TwiN TwiN closed this Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Bundle assets in binary
2 participants