Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would fix #47. But will need some more work and discussion.
Work that needs to be done
Things to consider
Modifications besides loading files using embed instead of from a directory.
In
spa.go
it will no longer write to the client on errors. This could be fixed, but I don't think it's necessary. If it still runs even when there's an error I think it only hides the error.I removed
favicon.go
androuter.HandleFunc("/favicon.ico", FavIcon(staticFolder)).Methods("GET")
because the catch all route can handle it.