Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move from io/ioutil to io and os packages #211

Merged
merged 1 commit into from
Dec 4, 2021
Merged

refactor: move from io/ioutil to io and os packages #211

merged 1 commit into from
Dec 4, 2021

Conversation

Juneezee
Copy link
Contributor

@Juneezee Juneezee commented Dec 3, 2021

The io/ioutil package has been deprecated in Go 1.16 (See https://golang.org/doc/go1.16#ioutil). Since gatus has been upgraded to Go 1.17 in babe7b0, This PR replaces the existing io/ioutil functions with their new definitions in io and os packages.

The io/ioutil package has been deprecated as of Go 1.16, see
https://golang.org/doc/go1.16#ioutil. This commit replaces the existing
io/ioutil functions with their new definitions in io and os packages.

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #211 (7a05bdc) into master (5eb7763) will decrease coverage by 0.10%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #211      +/-   ##
==========================================
- Coverage   84.48%   84.38%   -0.11%     
==========================================
  Files          49       49              
  Lines        2984     2984              
==========================================
- Hits         2521     2518       -3     
- Misses        351      353       +2     
- Partials      112      113       +1     
Impacted Files Coverage Δ
alerting/provider/twilio/twilio.go 48.48% <0.00%> (ø)
config/config.go 78.94% <0.00%> (ø)
storage/store/memory/memory.go 68.91% <0.00%> (ø)
alerting/provider/pagerduty/pagerduty.go 71.01% <50.00%> (ø)
alerting/provider/custom/custom.go 95.83% <100.00%> (ø)
alerting/provider/discord/discord.go 89.83% <100.00%> (ø)
alerting/provider/mattermost/mattermost.go 91.54% <100.00%> (ø)
alerting/provider/messagebird/messagebird.go 81.81% <100.00%> (ø)
alerting/provider/slack/slack.go 89.83% <100.00%> (ø)
alerting/provider/teams/teams.go 89.83% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5eb7763...7a05bdc. Read the comment docs.

Copy link
Owner

@TwiN TwiN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@TwiN TwiN merged commit f89447b into TwiN:master Dec 4, 2021
@TwiN
Copy link
Owner

TwiN commented Jan 9, 2022

Released in v3.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants