feat(security): Implement Bcrypt for basic auth and deprecate SHA512 #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've re-written the code for this several times before but always ended up not going through with it because a hashed Bcrypt string has dollar signs in it, which caused issues with the config due to environment variable support. I finally decided to go through with it by forcing users to base64 encode the bcrypt hash
Codecov Report
@@ Coverage Diff @@
## master #233 +/- ##
==========================================
+ Coverage 83.20% 83.27% +0.07%
==========================================
Files 52 52
Lines 3293 3313 +20
==========================================
+ Hits 2740 2759 +19
- Misses 430 431 +1
Partials 123 123
Continue to review full report at Codecov.
|
|
Released in v3.5.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've re-written the code for this several times in the past before but always ended up not going all the way through with it because a hashed Bcrypt string has dollar signs in it, which caused issues with the config file due to environment variable support.
I finally decided to go through with it by forcing users to base64 encode the bcrypt hash.
The bottom line is, it was irresponsible of me to add support for SHA512 in the first place; it is a fast hash, and is not intended to be used as password.