Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(alerting): Add group-specific configuration to email provider #264

Merged
merged 7 commits into from
Mar 21, 2022

Conversation

appleboy
Copy link
Contributor

Add group-specific to list for email alert

Provides support for paging multiple teams based on the group selector while keeping backward compatibility to the old email configuration manifest

integration per team can be specified in the overrides sections in an array form.

alerting:
  email:
    from: "from@example.com"
    username: "from@example.com"
    password: "hunter2"
    host: "mail.example.com"
    port: 587
    to: "recipient1@example.com,recipient2@example.com"
    overrides:
      - group: "core"
        to: "recipient3@example.com,recipient4@example.com"

ref: #96

Signed-off-by: Bo-Yi Wu appleboy.tw@gmail.com

Add group-specific to list for email alert

TwiN#96

Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
README.md Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2022

Codecov Report

Merging #264 (bf77fb4) into master (0bf2271) will increase coverage by 0.06%.
The diff coverage is 93.33%.

@@            Coverage Diff             @@
##           master     #264      +/-   ##
==========================================
+ Coverage   83.57%   83.64%   +0.06%     
==========================================
  Files          53       53              
  Lines        3434     3448      +14     
==========================================
+ Hits         2870     2884      +14     
  Misses        439      439              
  Partials      125      125              
Impacted Files Coverage Δ
alerting/provider/email/email.go 72.72% <93.33%> (+9.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bf2271...bf77fb4. Read the comment docs.

Copy link
Owner

@TwiN TwiN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@TwiN TwiN added feature New feature or request area/alerting Related to alerting labels Mar 21, 2022
@TwiN TwiN merged commit a81c81e into TwiN:master Mar 21, 2022
@appleboy appleboy deleted the email branch March 21, 2022 03:35
@TwiN TwiN changed the title feat(alert): Add group-specific to email list feat(alerting): Add group-specific configuration to email provider Mar 23, 2022
@TwiN
Copy link
Owner

TwiN commented Mar 23, 2022

Released in v3.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/alerting Related to alerting feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants