Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ux: Improve endpoint validation by checking type on start #323

Merged
merged 4 commits into from
Sep 2, 2022

Conversation

TwiN
Copy link
Owner

@TwiN TwiN commented Sep 2, 2022

Summary

This PR improves user experience by validating endpoint type on start and including the endpoint display name in the error, which should allow the user to find the culprit more easily.

Checklist

  • Tested and/or added tests to validate that the changes work as intended, if applicable.
  • Added the documentation in README.md, if applicable.

@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2022

Codecov Report

Merging #323 (657dca4) into master (daf8e3a) will decrease coverage by 0.05%.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##           master     #323      +/-   ##
==========================================
- Coverage   83.02%   82.97%   -0.06%     
==========================================
  Files          54       54              
  Lines        3859     3864       +5     
==========================================
+ Hits         3204     3206       +2     
- Misses        512      514       +2     
- Partials      143      144       +1     
Impacted Files Coverage Δ
core/endpoint.go 76.11% <50.00%> (-0.93%) ⬇️
config/config.go 73.54% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@TwiN TwiN merged commit 4857b43 into master Sep 2, 2022
@TwiN TwiN deleted the better-endpoint-validation branch September 2, 2022 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants