feat(alerting): add client config for telegram #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well, I see now that I just have to build the docker image... |
TwiN
reviewed
Sep 6, 2022
Codecov Report
@@ Coverage Diff @@
## master #324 +/- ##
==========================================
+ Coverage 82.97% 82.98% +0.01%
==========================================
Files 54 54
Lines 3864 3867 +3
==========================================
+ Hits 3206 3209 +3
Misses 514 514
Partials 144 144
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Co-authored-by: TwiN <twin@linux.com>
|
I've removed the example as requested |
TwiN
approved these changes
Sep 7, 2022
There was a problem hiding this comment.
Excellent work @lschloetterer.
Since you mentioned not being familiar with Go, I'll take care of writing some tests for you.
Thank you for the contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds an option to specify the client config for the telegram alerting provider.
I'm monitoring a local dns server, so the notifications should still go through if the local dns is down.
Builds on top of #284
I have to admit I have never worked with Go before, so I'm not sure how to compile and test the project, but this change seems relatively straighforward.
Checklist
README.md, if applicable.