feat: Add [DOMAIN_EXPIRATION] placeholder for monitoring domain expiration using WHOIS #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation using WHOIS
Codecov Report
@@ Coverage Diff @@
## master #325 +/- ##
==========================================
- Coverage 82.97% 82.89% -0.08%
==========================================
Files 54 54
Lines 3864 3899 +35
==========================================
+ Hits 3206 3232 +26
- Misses 514 518 +4
- Partials 144 149 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
TwiN
commented
Sep 6, 2022
Comment on lines
-254
to
-263
| if endpoint.DNS != nil { | ||
| result.Hostname = strings.TrimSuffix(endpoint.URL, ":53") | ||
| } else { | ||
| urlObject, err := url.Parse(endpoint.URL) | ||
| if err != nil { | ||
| result.AddError(err.Error()) | ||
| return | ||
| } | ||
| result.Hostname = urlObject.Hostname() | ||
| } |
There was a problem hiding this comment.
That didn't belong there in the first place, not sure why I put that there.
TwiN
added a commit
that referenced
this pull request
Sep 7, 2022
…doesn't already exist This will prevent temporary issues with the parsing of old results that would otherwise have a value of NULL for domain_expiration Fixes an issue introduced by #325
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #133
This feature allows users to monitor domain expiration by leveraging the WHOIS protocol through the TwiN/whois library.
Here's an example of what an endpoint configured to monitor
Checklist
README.md, if applicable.