Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(alerting): Implement ntfy provider #336

Merged
merged 8 commits into from
Oct 9, 2022
Merged

feat(alerting): Implement ntfy provider #336

merged 8 commits into from
Oct 9, 2022

Conversation

TwiN
Copy link
Owner

@TwiN TwiN commented Oct 5, 2022

Summary

Closes #308

Work remaining:

  • Add the documentation on the README.md
  • Test it with an actual Ntfy instance (I've only used https://ntfy.sh/docs/examples/#gatus as a reference; I haven't actually tested it yet)

Checklist

  • Tested and/or added tests to validate that the changes work as intended, if applicable.
  • Added the documentation in README.md, if applicable.

Closes #308

Work remaining:
- Add the documentation on the README.md
- Test it with an actual Ntfy instance (I've only used https://ntfy.sh/docs/examples/#gatus as a reference; I haven't actually tested it yet)
@TwiN TwiN added feature New feature or request help wanted Extra attention is needed area/alerting Related to alerting labels Oct 5, 2022
@TwiN
Copy link
Owner Author

TwiN commented Oct 5, 2022

If somebody has the time to test it with Ntfy, please do so and let me know if it works and/or what adjustment should be made🙏

@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2022

Codecov Report

Base: 82.80% // Head: 82.47% // Decreases project coverage by -0.33% ⚠️

Coverage data is based on head (657efa9) compared to base (be88af5).
Patch coverage: 54.34% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #336      +/-   ##
==========================================
- Coverage   82.80%   82.47%   -0.34%     
==========================================
  Files          54       55       +1     
  Lines        3902     3948      +46     
==========================================
+ Hits         3231     3256      +25     
- Misses        521      541      +20     
- Partials      150      151       +1     
Impacted Files Coverage Δ
alerting/provider/provider.go 100.00% <ø> (ø)
alerting/provider/ntfy/ntfy.go 53.33% <53.33%> (ø)
config/config.go 73.68% <100.00%> (+0.13%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TwiN TwiN merged commit 47dd18a into master Oct 9, 2022
@TwiN TwiN deleted the ntfy branch October 9, 2022 20:45
TwiN added a commit that referenced this pull request Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/alerting Related to alerting feature New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(alerting): Implement ntfy provider
3 participants