Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Bundle assets in binary using go:embed #340

Merged
merged 1 commit into from
Oct 10, 2022
Merged

feat: Bundle assets in binary using go:embed #340

merged 1 commit into from
Oct 10, 2022

Conversation

TwiN
Copy link
Owner

@TwiN TwiN commented Oct 9, 2022

Summary

Fixes #47

Checklist

  • Tested and/or added tests to validate that the changes work as intended, if applicable.
  • Added the documentation in README.md, if applicable.

@TwiN TwiN added the feature New feature or request label Oct 9, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 82.47% // Head: 82.39% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (3a91221) compared to base (47dd18a).
Patch coverage: 70.58% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #340      +/-   ##
==========================================
- Coverage   82.47%   82.39%   -0.08%     
==========================================
  Files          55       54       -1     
  Lines        3948     3948              
==========================================
- Hits         3256     3253       -3     
- Misses        541      543       +2     
- Partials      151      152       +1     
Impacted Files Coverage Δ
controller/handler/spa.go 64.70% <62.50%> (-1.97%) ⬇️
controller/handler/handler.go 77.41% <71.42%> (-5.34%) ⬇️
config/ui/ui.go 63.88% <100.00%> (ø)
controller/controller.go 95.45% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TwiN TwiN merged commit 00b56ec into master Oct 10, 2022
@TwiN TwiN deleted the embed branch October 10, 2022 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Bundle assets in binary
2 participants