Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Allow configuring meta description #342

Merged
merged 8 commits into from
Nov 1, 2022
Merged

Conversation

davwheat
Copy link
Contributor

@davwheat davwheat commented Oct 14, 2022

Summary

Closes #345

  • Allow users to set ui.description to set the <meta property="description" /> for their status page

Checklist

  • Tested and/or added tests to validate that the changes work as intended, if applicable.
  • Added the documentation in README.md, if applicable.

README.md Outdated Show resolved Hide resolved
web/app/public/index.html Show resolved Hide resolved
@TwiN TwiN added the feature New feature or request label Oct 16, 2022
README.md Outdated Show resolved Hide resolved
TwiN
TwiN previously approved these changes Oct 17, 2022
@TwiN TwiN dismissed their stale review October 17, 2022 04:10

Looks like there's a small typo in the code 😔

config/ui/ui_test.go Outdated Show resolved Hide resolved
@TwiN
Copy link
Owner

TwiN commented Nov 1, 2022

I will push the static files shortly after this PR (forgive me for my laziness 🙏 of not doing it directly in this PR, future self)

@TwiN TwiN changed the title feat: allow configuring meta description in config feat(ui): Allow configuring meta description Nov 1, 2022
@TwiN TwiN merged commit 22d74a5 into TwiN:master Nov 1, 2022
@TwiN
Copy link
Owner

TwiN commented Nov 1, 2022

Generated assets in fed0218

@TwiN
Copy link
Owner

TwiN commented Nov 1, 2022

Thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to set HTML meta description
2 participants