feat: support SCTP & UDP as endpoint type #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @TwiN |
TwiN
requested changes
Nov 1, 2022
There was a problem hiding this comment.
Can you add tests & document how to monitor an UDP and a SCTP endpoint?
For the documentation part, there's an example here: Monitoring a TCP endpoint
ianchen0119
force-pushed
the
feat/support-udp-and-sctp
branch
from
6aaae6c
to
1fa3cba
Compare
|
Done 👍 |
ianchen0119
force-pushed
the
feat/support-udp-and-sctp
branch
from
e8e5914
to
e198e04
Compare
Codecov ReportBase: 82.68% // Head: 82.06% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #352 +/- ##
==========================================
- Coverage 82.68% 82.06% -0.62%
==========================================
Files 54 54
Lines 3990 4025 +35
==========================================
+ Hits 3299 3303 +4
- Misses 539 568 +29
- Partials 152 154 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
TwiN
approved these changes
Nov 10, 2022
|
Thank you for the contribution! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related Issue: #333
I added the handlers on sctp and udp protocol.
Cause I want to use gatus to monitor all the interfaces on 5G core network.
Checklist
README.md, if applicable.