Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(alerting): Implement GitHub alerting provider #387

Merged
merged 1 commit into from
Dec 16, 2022

Conversation

TwiN
Copy link
Owner

@TwiN TwiN commented Dec 16, 2022

Summary

Closes #378

github-alerts

Checklist

  • Tested and/or added tests to validate that the changes work as intended, if applicable.
  • Added the documentation in README.md, if applicable.

@TwiN TwiN added feature New feature or request area/alerting Related to alerting labels Dec 16, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 82.04% // Head: 82.06% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (8c85ea7) compared to base (27502ac).
Patch coverage: 82.92% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #387      +/-   ##
==========================================
+ Coverage   82.04%   82.06%   +0.01%     
==========================================
  Files          54       55       +1     
  Lines        4066     4148      +82     
==========================================
+ Hits         3336     3404      +68     
- Misses        574      587      +13     
- Partials      156      157       +1     
Impacted Files Coverage Δ
alerting/provider/provider.go 100.00% <ø> (ø)
alerting/provider/github/github.go 82.71% <82.71%> (ø)
config/config.go 73.26% <100.00%> (+0.14%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TwiN TwiN merged commit ecc0636 into master Dec 16, 2022
@TwiN TwiN deleted the feat/alerting-github branch December 16, 2022 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/alerting Related to alerting feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(alerting): Support GitHub as an alerting provider (issues)
2 participants