Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tls): Pass certificate and private key files to listener method #531

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

TwiN
Copy link
Owner

@TwiN TwiN commented Jul 20, 2023

Summary

Fixes #530

Checklist

  • Tested and/or added tests to validate that the changes work as intended, if applicable.
  • Updated documentation in README.md, if applicable.

@TwiN TwiN added the bug Something isn't working label Jul 20, 2023
@TwiN TwiN changed the title fix(tls): Pass certificate and private files to listener method fix(tls): Pass certificate and private key files to listener method Jul 20, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 20.00% and project coverage change: -0.12 ⚠️

Comparison is base (2f6b8f2) 81.69% compared to head (a2daac5) 81.58%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #531      +/-   ##
==========================================
- Coverage   81.69%   81.58%   -0.12%     
==========================================
  Files          56       56              
  Lines        4349     4350       +1     
==========================================
- Hits         3553     3549       -4     
- Misses        615      619       +4     
- Partials      181      182       +1     
Impacted Files Coverage Δ
controller/controller.go 55.55% <0.00%> (-17.18%) ⬇️
config/web/web.go 93.10% <60.00%> (+11.28%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TwiN TwiN merged commit fd17dcd into master Jul 20, 2023
3 checks passed
@TwiN TwiN deleted the fix/tls branch July 20, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TLS configuration doesn't work in v5.5.0
2 participants