Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(alerting): correct success threshold for telegram #551

Merged
merged 1 commit into from Aug 17, 2023

Conversation

plantatorbob
Copy link
Contributor

Summary

There is a typo in Telegram alerting provider implementation: for resolved alerts, instead of success count, failure count is printed instead.

This PR fixes the typo and adjusts relevant test cases.

Checklist

  • Tested and/or added tests to validate that the changes work as intended, if applicable.
  • Updated documentation in README.md, if applicable.

Copy link
Owner

@TwiN TwiN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (5c5a954) 81.02% compared to head (50fa3a7) 81.02%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #551   +/-   ##
=======================================
  Coverage   81.02%   81.02%           
=======================================
  Files          56       56           
  Lines        4391     4391           
=======================================
  Hits         3558     3558           
- Misses        650      651    +1     
+ Partials      183      182    -1     
Files Changed Coverage Δ
alerting/provider/telegram/telegram.go 83.63% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TwiN TwiN merged commit 6794186 into TwiN:master Aug 17, 2023
2 checks passed
@TwiN
Copy link
Owner

TwiN commented Aug 17, 2023

Thank you for the contribution!

@TwiN TwiN added bug Something isn't working area/alerting Related to alerting labels Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/alerting Related to alerting bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants