-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crossbuild docker image for different architectures #55
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't this just create multi-arch images for the latest tag?
I was initially planning on using a manifest instead of buildx and using Docker Hub's build rules to build the images rather than leveraging a GitHub action
Co-authored-by: Chris C. <twin@twinnation.org>
It would create image for the latest tag. You may specify your custom tag or list of tags, even git commit. |
Alright, I've had a closer look and could you make the following changes?:
on:
release:
types: [published] That way we should be able to use the Let me know if you need help. |
Thank you for your contribution @Pentusha, and sorry for the delay. I've had a busy week 😅 |
Released in v1.9.1 P.S. I've also removed |
For issue #54
In order to use this code, you need to setup secrets in the repository. Repo settings -> Secrets
DOCKER_USERNAME
DOCKER_PASSWORD