simpler code

Twingate · May 13, 2024 · 76187e7 · 76187e7
1 parent 24c1db9
commit 76187e7
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 17 deletions.
diff --git a/app/handlers/handlers_services.py b/app/handlers/handlers_services.py
@@ -52,20 +52,19 @@ def service_to_twingate_resource(service_body, namespace) -> dict:
         if value := meta.annotations.get(f"twingate.com/resource-{key}"):
             result["spec"][key] = convert_f(value)
 
-    if service_ports := spec.get("ports", []):
-        protocols: dict = {
-            "allowIcmp": False,
-            "tcp": {"policy": "RESTRICTED", "ports": []},
-            "udp": {"policy": "RESTRICTED", "ports": []},
-        }
-        for port_obj in service_ports:
-            port = port_obj["port"]
-            if port_obj["protocol"] == "TCP":
-                protocols["tcp"]["ports"].append({"start": port, "end": port})
-            elif port_obj["protocol"] == "UDP":
-                protocols["udp"]["ports"].append({"start": port, "end": port})
-
-        result["spec"]["protocols"] = protocols
+    protocols: dict = {
+        "allowIcmp": False,
+        "tcp": {"policy": "RESTRICTED", "ports": []},
+        "udp": {"policy": "RESTRICTED", "ports": []},
+    }
+    for port_obj in spec.get("ports", []):
+        port = port_obj["port"]
+        if port_obj["protocol"] == "TCP":
+            protocols["tcp"]["ports"].append({"start": port, "end": port})
+        elif port_obj["protocol"] == "UDP":
+            protocols["udp"]["ports"].append({"start": port, "end": port})
+
+    result["spec"]["protocols"] = protocols
 
     return result
 

diff --git a/app/handlers/tests/test_handlers_services.py b/app/handlers/tests/test_handlers_services.py
@@ -42,9 +42,7 @@ def example_service_body():
           targetPort: 9376
           name: ssh
     """
-    return kopf._cogs.structs.bodies.Body(  # noqa: SLF001
-        yaml.safe_load(yaml_str)
-    )
+    return kopf.Body(yaml.safe_load(yaml_str))
 
 
 @pytest.fixture()