GKE helm provider deployment guide #109
Conversation
There was a problem hiding this comment.
@romankor left some more specific comments, but basically let's add a variables definition section up front in the guide so that the variables in the rest of the example refer to how we've defined them.
| provider "google" { | ||
| project = var.project_id | ||
| region = var.region | ||
| zone = var.zone | ||
| } |
There was a problem hiding this comment.
See my comment below, too, but let's create a new section in the guide that defines all the variables that are used with placeholder examples. That allows someone to literally copy & paste as they go without guessing on our intent.
|
|
||
| set { | ||
| name = "connector.network" | ||
| value = var.network |
There was a problem hiding this comment.
This variable isn't defined anywhere, so in line with my comment above, let's create a new variables example section in this guide. Right now we have "autoco" set in the Twingate provider config manually.
| ```terraform | ||
| provider "twingate" { | ||
| api_token = "1234567890abcdef" | ||
| network = "autoco" |
There was a problem hiding this comment.
Let's convert this to a variable definition.
Changes