Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo: Create workspace for all crates; fmt all crates #18

Merged
merged 3 commits into from Jun 29, 2022

Conversation

MarijnS95
Copy link
Contributor

@MarijnS95 MarijnS95 commented Jun 25, 2022

Depends on #17

By creating a workspace various cargo commands go over every crate in this workspace instead of only looking at, linting, or formatting the root ispc crate (and any local crate that happens to be in its [dependencies]).

@MarijnS95
Copy link
Contributor Author

Will clean up some of the CI scripts before getting this in :)

By creating a workspace various cargo commands go over every crate in
this workspace instead of only looking at, linting, or formatting the
root `ispc` crate (and any local crate that happens to be in its
`[dependencies]`).
Note that these script didn't include the `compile` and `runtime`
subcrates, which were also missing from the workspace hence never
checked for formatting either.
@MarijnS95 MarijnS95 changed the title cargo: Create workspace and add all crates to it cargo: Create workspace for all crates; fmt all crates Jun 29, 2022
@Twinklebear
Copy link
Owner

Thanks @MarijnS95 this looks great! I didn't know about Cargo workspaces, that's very convenient to have

@Twinklebear Twinklebear merged commit d5ae53e into Twinklebear:master Jun 29, 2022
@MarijnS95 MarijnS95 deleted the workspace branch June 29, 2022 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants