Add missing edition = "2021" to compile and runtime crates
#21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit ad85f13 ("Seems like edition in workspace isn't applied? Update all to 2021") found that `workspace.edition` isn't a valid key and added it to most crates' individual `[package]` table, but didn't remove the key from `[workspace]` nor added it to the `compile` and `runtime` crates. Note that `[workspace.package] edition = "2021"` exists since Rust 1.64, but still requires `[package] edition.workspace = true` to be repeated in every individual `Cargo.toml` for it to be inherited: https://doc.rust-lang.org/cargo/reference/workspaces.html#the-package-table
This was referenced Oct 20, 2022
|
Thanks for the fix @MarijnS95 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit ad85f13 ("Seems like edition in workspace isn't applied? Update all to 2021") found that
workspace.editionisn't a valid key and added it to most crates' individual[package]table, but didn't remove the key from[workspace]nor added it to thecompileandruntimecrates:Note that
[workspace.package] edition = "2021"exists since Rust 1.64, but still requires[package] edition.workspace = trueto be repeated in every individualCargo.tomlfor it to be inherited: https://doc.rust-lang.org/cargo/reference/workspaces.html#the-package-table