CI: Drop unnecessary actions-rs toolchain setup
#24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub's `runner-images` already come preloaded with all the Rust components needed, and `actions-rs` hasn't been maintained for the longest time and is now spitting useless NodeJS deprecation warnings. Fortunately this CI script is already using plain `run: cargo ...`, other repos were using the slower, more verbose and less relatable `actions-rs/cargo` step for this.
|
Looks great, thanks @MarijnS95 ! I'll have to update my other repos to move off |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub's
runner-imagesalready come preloaded with all the Rust components needed, andactions-rshasn't been maintained for the longest time and is now spitting useless NodeJS deprecation warnings.Fortunately this CI script is already using plain
run: cargo ..., other repos were using the slower, more verbose and less relatableactions-rs/cargostep for this.Sidenote: this may not update to the latest
stableas soon as it releases, but that'd be easy to fix with arun: rustup updateif desired - even if slower than giving GitHub a few days to propagate updated containers through their ecosystem.