#386 Fix Hunter threshold line Lua and error spam.

Twintop · May 9, 2024 · 56227e4 · 56227e4
1 parent 9687586
commit 56227e4
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 4 deletions.
diff --git a/ClassModules/Hunter.lua b/ClassModules/Hunter.lua
@@ -567,9 +567,9 @@ local function ConstructResourceBar(settings)
 		end
 	end
 
+	local thresholdId = 1
 	for _, v in pairs(spells) do
 		local spell = v --[[@as TRB.Classes.SpellBase]]
-		local thresholdId = 1
 		if (spell:Is("TRB.Classes.SpellThreshold") or spell:Is("TRB.Classes.SpellComboPointThreshold")) and spell:IsValid() then
 			spell = spell --[[@as TRB.Classes.SpellThreshold]]
 			if resourceFrame.thresholds[thresholdId] == nil then
@@ -1530,7 +1530,7 @@ local function UpdateResourceBar()
 					if (spell:Is("TRB.Classes.SpellThreshold") or spell:Is("TRB.Classes.SpellComboPointThreshold")) and spell:IsValid() then
 						spell = spell --[[@as TRB.Classes.SpellThreshold]]
 						local resourceAmount = -spell:GetPrimaryResourceCost()
-						TRB.Functions.Threshold:RepositionThreshold(specSettings, resourceFrame.thresholds[thresholdId], resourceFrame, -resourceAmount, TRB.Data.character.maxResource)
+						TRB.Functions.Threshold:RepositionThreshold(specSettings, resourceFrame.thresholds[thresholdId], resourceFrame, -resourceAmount, TRB.Data.character.maxResource, spell)
 
 						local showThreshold = true
 						local thresholdColor = specSettings.colors.threshold.over

diff --git a/Functions/News.lua b/Functions/News.lua
@@ -11,6 +11,13 @@ local content = [====[
 
 ---
 
+# 10.2.7.4-release (2024-05-09)
+## Hunter
+
+- [#386 - FIX (Twintop)](#386) Fix threshold line creation and subsequent Lua errors and warning chat window spam.
+
+---
+
 # 10.2.7.3-release (2024-05-09)
 ## Priest
 ### Holy

diff --git a/Functions/Threshold.lua b/Functions/Threshold.lua
@@ -29,7 +29,6 @@ end
 
 function TRB.Functions.Threshold:RepositionThreshold(settings, thresholdLine, parentFrame, resourceThreshold, resourceMax, debug)
 	if settings == nil or settings.bar == nil or thresholdLine == nil then
-		print(L["RepositionThresholdInvalid"])
 		return
 	end
 

diff --git a/TwintopInsanityBar.toc b/TwintopInsanityBar.toc
@@ -13,7 +13,7 @@
 ## Title-zhTW: Twintop 的資源欄
 ## Author: Twintop
 ## X-AuthorServer: Frostmourne-US/OCE
-## Version: 10.2.7.3
+## Version: 10.2.7.4
 ## X-ReleaseType: release
 ## X-ReleaseDate: 2024-05-09
 ## SavedVariables: TwintopInsanityBarSettings