Fix many formatting asserts and make epoch time initialization safer and faster #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Pavel, I've decided to merge the PR, At a later stage I'll implement a single function to to handle all the epoch time calculations to reduce the amount of redundant code, but at the moment I want to finish the MOB & DSC code, fix a few errors in twocanencoder (the NMEA 183 to NMEA 2000 conversion) and get the next release out. Thanks for your help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure this is the right branch, but it had the latest changes...
There still are some
wxDateTime::ParseDateTimecalls that somewhat scare me in the conversion logic intwocanencoder.cpp, but I'm not sure I understand the logic without some more study, I generaly tend to trustwxDateTime::ParseISOCombinedto give me what I expect much more.