fix(core): perform byte array <-> b64 conversions w/ native JS #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tsconfig setting adds `| undefined` whenever you access undeclared properties of an object/array. It defaults to false. Overriding the default and setting this to true forces the use of non-null assertion operators in places where I've already confirmed a property exists. The extra protection it adds isn't worth the trade-off. See https://www.typescriptlang.org/tsconfig#noUncheckedIndexedAccess
|
@acfunk would be great to have you take a look at this 🙏 |
lgtm |
This was referenced Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of requiring consuming applications to use the Node.js
BufferAPI polyfill to convertUint8Arraybyte arrays to and from base 64 strings, wallet clients will now use native JavaScript methodsatobandbtoa.Credit to PureStake, as utility functions for AlgoSigner were starting points for the functions now being used here: https://github.com/PureStake/algosigner/blob/master/packages/common/src/encoding.ts
Other Changes
I've also updated the core library's tsconfig to no longer enforce
noUncheckedIndexedAccess, which forces me to use non-null assertion operators to access numbered array elements. This trade-off for the benefit it provides by strictly enforcing declared object properties doesn't seem worth it. I would've had to use it (again) in thebyteArrayToStringfunction. See https://www.typescriptlang.org/tsconfig#noUncheckedIndexedAccess