You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First thank you very much for this repo, it is very helpful for people who are new to BNNs like me.
I have started to use TyXe for a convolutional BNN, starting from your resnet.py example.
After getting some unexpected behavior during training I have noticed that in the callback function the network was not set into evalutation mode. It is resulting in an important data leakage by training the network on the test dataset as well if I am correct.
I would recommend to start and finish the callback function with respectively b.eval() and b.train().
Hope this helps,
Regards!
The text was updated successfully, but these errors were encountered:
Cam-B04
added a commit
to Cam-B04/TyXe
that referenced
this issue
Aug 22, 2022
Thanks spotting this and the PR! I don't think it's overkill at all, I'll merge it right away, sorry for only getting back to you now.
Technically I wouldn't really call this data leakage since training won't be affected by the test data, but it does break independence between the test predictions, so I definitely should have included the eval and train calls :)
Hi !
First thank you very much for this repo, it is very helpful for people who are new to BNNs like me.
I have started to use TyXe for a convolutional BNN, starting from your resnet.py example.
After getting some unexpected behavior during training I have noticed that in the callback function the network was not set into evalutation mode. It is resulting in an important data leakage by training the network on the test dataset as well if I am correct.
I would recommend to start and finish the callback function with respectively
b.eval()
andb.train()
.Hope this helps,
Regards!
The text was updated successfully, but these errors were encountered: