initial fully customized sign in and registration example #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed working example w/ @merlinoa, then:
Other:
|
phoward38
reviewed
Jul 9, 2020
R/email_input.R
Outdated
| email_input <- function (inputId, label, value = "", width = NULL, placeholder = NULL) { | ||
| email_input <- function ( | ||
| inputId, | ||
| label = tagList(icon("envelope"), "Email"), |
There was a problem hiding this comment.
Added default label like password_input
phoward38
reviewed
Jul 9, 2020
| - "register_password_verify" | ||
| - "submit_register" | ||
|
|
||
| And when passing your custom module UI as the `sign_in_page_ui` argument in the `secure_ui` function, you **must** use `sign_in` as the UI module's ID (as shown in the example below). |
There was a problem hiding this comment.
Added note about required sign_in ID for custom UI module
phoward38
approved these changes
Jul 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@phoward can you please take a look at this?
It adds a more formal structure to creating fully customized sign in and registration pages with polished. I think it still needs a little work though. Can you follow the new vignette and try and set up a fully customize sign in + registration page and let me know what you think.