Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boring crypto #8

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
+16 −5
Open

Boring crypto #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fbbb6f9
Boring crypto
buger Feb 14, 2023
fe2456d
Update release.yml
buger Feb 14, 2023
337ef19
Update Dockerfile
buger Feb 14, 2023
c20378f
Update Dockerfile
buger Feb 14, 2023
e231cce
Update release.yml
buger Feb 14, 2023
5b07352
Update Dockerfile
buger Feb 15, 2023
f5d0cc1
Update release.yml
buger Feb 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,21 +13,30 @@ jobs:
strategy:
fail-fast: false
matrix:
image:
- "golang"
gover:
- "1.16"
- "1.17"
- "1.18"
- "1.19"
- "1.20"
debver:
- buster
- bullseye
- "-buster"
- "-bullseye"
include:
- gover: "1.15"
debver: stretch
debver: "-stretch"
image: "golang"
tag: el7
- gover: "1.15"
debver: buster
debver: "-buster"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

          - image: "goboring/golang"
            debver: ""
            gover: "1.16.7b7"
            tag: fips

1.16.7b7 is not a value in the gover matrix. So this rule will not match.

Copy link
Member Author

@buger buger Feb 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.16.7b7 is not a value in the gover matrix. So this rule will not match.

Well it is a version, it just have 2 layers of versioning. 1.16.7 is version of go, and b7 is seventh patch of boringcryto.
So better add new variable like "GO_VERSION_SUFFIX"?

Copy link
Member Author

@buger buger Feb 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes 1.19+ have boringcrypto embedded, but we moved it to 5.1, so for now 1.16 is what we need.
Goal is to have a PoC first. And yes OS/Docker image hardening is part of FIPS work, BUT, we may just say customer to install packages or build docker by themselves (even if on top of our image).

image: "golang"
- image: "goboring/golang"
debver: ""
gover: "1.16.7b7"
tag: fips


runs-on: ubuntu-latest

Expand All @@ -51,3 +60,4 @@ jobs:
build-args: |
GO_VERSION=${{ matrix.gover }}
DEB_VERSION=${{ matrix.debver }}
GO_IMAGE=${{ matrix.image }}
3 changes: 2 additions & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@

ARG GO_VERSION=1.15.15
ARG DEB_VERSION=stretch
ARG GO_IMAGE=golang

FROM golang:${GO_VERSION}-${DEB_VERSION} AS base
FROM ${GO_IMAGE}:${GO_VERSION}${DEB_VERSION} AS base

ARG DEB_VERSION
ARG DEBIAN_FRONTEND=noninteractive
Expand Down