introduce CustomExecutionEngineV2 #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buraksezer
approved these changes
Apr 25, 2023
rhianeKobar
approved these changes
Apr 26, 2023
pvormste
force-pushed
the
feat/TT-8731/custom-execution-engine-v2
branch
from
e79b409
to
b1cd2ae
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR are based on @buraksezer 's awesome research in this commit: 23f7686
This PR introduces interfaces for a
CustomExecutionEngineV2including execution stages.By introducing those changes it will be possible to provide its own
ExecutionEngineV2or decorate the already implementedExecutionEngineV2.Changes:
ExecutionEngineV2.Executeto track performance impacts with this change (none so far)CustomExecutionEngineV2NormalizerStage(optional)CustomExecutionEngineV2ValidatorStage(optional)CustomExecutionEngineV2ResolverStage(required)ExecutionEngineV2ExecutorExecutionEngineV2ExecutorcalledCustomExecutionEngineV2ExecutorExecutionEngineV2now implements all interfaces mentioned before and decorates theCustomExecutionEngineV2Executor(so it is basically aCustomExecutionEngineV2)internalExecutionContexttoCustomExecutionEngineV2as it is an implementation detailExecutionOptionsV2are now decoupled frominternalExecutionContextso that implementing them outside of thegraphqlpackage is now possible