Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TT-11091] Fixing Keys method to fetch all the keys when scanning #110

Merged
merged 3 commits into from
Feb 6, 2024

Conversation

mativm02
Copy link
Contributor

@mativm02 mativm02 commented Feb 5, 2024

Description

There was an issue when trying to fetch keys from Redis. The scan method wasn't being iterated, making it not return all the expected keys. It has been fixed, and a test with 50 keys has been added to ensure it works as expected.

Related Issue

https://tyktech.atlassian.net/browse/TT-11091?atlOrigin=eyJpIjoiNTEyMDk5MjMzYWVmNGRhMjlmY2M3OWQ0NzRiNzQ5NTEiLCJwIjoiaiJ9

Motivation and Context

Test Coverage For This Change

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)
  • Documentation updates or improvements.

Checklist

  • I have reviewed the guidelines for contributing to this repository.
  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • My change requires a change to the documentation.
    • I have manually updated the README(s)/documentation accordingly.
    • If you've changed APIs, describe what needs to be updated in the documentation.
  • I have updated the documentation accordingly.
  • Modules and vendor dependencies have been updated; run go mod tidy && go mod vendor
  • When updating library version must provide reason/explanation for this update.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Check your code additions will not fail linting checks:
    • gofmt -s -w .
    • go vet ./...

Copy link

sonarcloud bot commented Feb 5, 2024

@tbuchaillot tbuchaillot enabled auto-merge (squash) February 6, 2024 08:36
@tbuchaillot tbuchaillot merged commit 24ad76c into main Feb 6, 2024
14 checks passed
@tbuchaillot tbuchaillot deleted the TT-11091 branch February 6, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants