Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TT-10890 feat: Remove command override from gateway and pump #129

Merged
merged 5 commits into from Apr 5, 2024

Conversation

jakub-bochenski
Copy link
Contributor

Description

Remove command override from gateway and pump

Related Issue

#128

Motivation and Context

See #128

Test Coverage For This Change

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)
  • Documentation updates or improvements.

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • My change requires a change to the documentation.
    • I have manually updated the README(s)/documentation accordingly.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jakub-bochenski jakub-bochenski requested a review from a team as a code owner October 11, 2023 15:48
@jakub-bochenski jakub-bochenski requested review from buraksekili and removed request for a team October 11, 2023 15:48
@jakub-bochenski
Copy link
Contributor Author

Test failure is probably caused by missing secrets not the change

@caroltyk caroltyk changed the title feat: Remove command override from gateway and pump TT-10890 feat: Remove command override from gateway and pump Jan 3, 2024
@singhpr singhpr merged commit e687d26 into TykTechnologies:main Apr 5, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants