Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TT-10310 fix: Support latest image tag #137

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jakub-bochenski
Copy link
Contributor

Description

Refactor the condition for setting probes port to support latest tag and a manual override

Related Issue

#136

Motivation and Context

See #136

Test Coverage For This Change

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)
  • Documentation updates or improvements.

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • My change requires a change to the documentation.
    • I have manually updated the README(s)/documentation accordingly.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jakub-bochenski jakub-bochenski requested a review from a team as a code owner October 18, 2023 16:55
@jakub-bochenski jakub-bochenski requested review from komalsukhani and removed request for a team October 18, 2023 16:55
@komalsukhani
Copy link
Collaborator

@jakub-bochenski Can you update umbrella charts too?

@jakub-bochenski
Copy link
Contributor Author

@jakub-bochenski Can you update umbrella charts too?

done

@komalsukhani
Copy link
Collaborator

@jakub-bochenski Thank you for the contribution. I have approved your PR.
Will add this ticket to our backlog. Once it is scheduled for the release and QA tests it, we will merge it.

@komalsukhani komalsukhani changed the title fix: Support latest image tag [TT-10310] fix: Support latest image tag Oct 20, 2023
@caroltyk
Copy link
Collaborator

Hi @jakub-bochenski , thank you for the updates. This PR is scheduled for testing and release in v1.3.0 (tentatively at Jan 2024)

@caroltyk caroltyk changed the title [TT-10310] fix: Support latest image tag TT-10310 fix: Support latest image tag Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants