[TT-12125] Add fixed window rate limiter vars #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
titpetric
requested review from
komalsukhani and
andrei-tyk
and removed request for
a team
komalsukhani
requested changes
May 15, 2024
komalsukhani
approved these changes
May 16, 2024
|
@titpetric Is this PR tested by your QA? If it's already tested I can merge it. |
|
@komalsukhani if you mean the actual functionality, yes ; the helm charts, we (or our QA) never tested anything related to helm charts so far. Is there a testing guide we can follow? |
|
@titpetric Unfortunately we don't have a testing guide. Our QA(Pranshu) can help your QA in testing it. |
|
@titpetric Is this PR tested? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tyktech.atlassian.net/browse/TT-12125