Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enterprise portal + update smoke tests #222

Merged
merged 16 commits into from
Oct 18, 2022
Merged

Conversation

zalbiraw
Copy link
Member

@zalbiraw zalbiraw commented Aug 8, 2022

Description

Adds ability to launch an enterprise portal to tyk-pro

Related Issue

Motivation and Context

Test Coverage For This Change

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@zalbiraw zalbiraw requested a review from a team as a code owner August 8, 2022 16:01
@zalbiraw zalbiraw requested review from komalsukhani and removed request for a team August 8, 2022 16:01
@zalbiraw
Copy link
Member Author

zalbiraw commented Aug 8, 2022

What the PR is missing:

  • portal connection string should be a secret ✅
  • bootstrap script should bootstrap portal ✅
  • sqlite3 is not working. Seems to be a permission issue in creating the db file.
  • documentation ✅

@zalbiraw zalbiraw force-pushed the add-enterprise-portal branch 3 times, most recently from 1468ae6 to fba2d36 Compare August 22, 2022 21:50
@zalbiraw zalbiraw changed the title WIP: Add enterprise portal Add enterprise portal Aug 22, 2022
@zalbiraw
Copy link
Member Author

@caroltyk here is the PR for the docs.

@zalbiraw zalbiraw force-pushed the add-enterprise-portal branch 2 times, most recently from 9ef192c to 37281b3 Compare August 23, 2022 13:18
@zalbiraw
Copy link
Member Author

sqlite3 not working is expected. You need to mount a file on the file system for that to work. If we allow sqlite3 to create its own file on the container it will cause a lot of issues with data loss and data not being copied to different containers. So if someone wants to use sqlite3 they will need to create their own volumes and attach them to the containers.

PR is now ready for test.

@zalbiraw
Copy link
Member Author

Tested on minikube, EKS, and OpenShift with mysql and postgres.

@zalbiraw zalbiraw changed the base branch from master to TT-5702/openshift_security_context August 23, 2022 21:13
@zalbiraw zalbiraw changed the base branch from TT-5702/openshift_security_context to master August 23, 2022 22:15
@zalbiraw zalbiraw force-pushed the add-enterprise-portal branch 2 times, most recently from fa439cd to 9096b4f Compare August 24, 2022 15:21
@zalbiraw
Copy link
Member Author

Updated PR and smoke tests to the latest version.

@zalbiraw
Copy link
Member Author

Please don't merge before
#220
#226
#227

@zalbiraw zalbiraw force-pushed the add-enterprise-portal branch 2 times, most recently from 675ec26 to fd4c8c8 Compare August 31, 2022 14:28
@zalbiraw zalbiraw changed the base branch from master to bootstrap-binary-compatible August 31, 2022 14:29
@zalbiraw zalbiraw force-pushed the add-enterprise-portal branch 2 times, most recently from fdec10c to 7c6e2a5 Compare August 31, 2022 14:43
@zalbiraw
Copy link
Member Author

@andrei-tyk this should work ootb as long as you push your PR to the latest docker tag!

@zalbiraw zalbiraw changed the title Add enterprise portal Add enterprise portal + update smoke tests Aug 31, 2022
@zalbiraw zalbiraw changed the base branch from bootstrap-binary-compatible to master September 14, 2022 12:57
@zalbiraw zalbiraw force-pushed the add-enterprise-portal branch 2 times, most recently from 60394fd to 0910db1 Compare September 14, 2022 13:09
@@ -212,6 +212,10 @@ dash:
# and operatorSecret are set to true.
# Set false to disable creating a secret for Tyk Operator.
operatorSecret: true
# It creates a secret for Tyk Enterprise Developer Portal along with bootstraping dasboard. Enterprise Developer Portal
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# It creates a secret for Tyk Enterprise Developer Portal along with bootstraping dasboard. Enterprise Developer Portal
# It creates a secret for Tyk Enterprise Developer Portal along with bootstraping dashboard. Enterprise Developer Portal

# Determines whether or not the enterprise portal component should be installed.
enabled: false

# Eenterprise Portal will only bootstrap if the tyk-enterprise-portal-conf secret
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Eenterprise Portal will only bootstrap if the tyk-enterprise-portal-conf secret
# Enterprise Portal will only bootstrap if the tyk-enterprise-portal-conf secret

@singhpr singhpr merged commit f67219c into master Oct 18, 2022
@buraksekili buraksekili mentioned this pull request Oct 18, 2022
9 tasks
@zalbiraw zalbiraw deleted the add-enterprise-portal branch October 18, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants