Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TT-7029 Add ability to manage annotations for the MDCB and Dashboard services #231

Merged
merged 1 commit into from
Nov 11, 2022

Conversation

zalbiraw
Copy link
Member

@zalbiraw zalbiraw commented Sep 25, 2022

Description

This PR will allow the customers to add annotations to their services. This is required when deploying LoadBalancer types.

Related Issue

#230

Motivation and Context

Required by anyone who would like to deploy these Tyk services as LBs.

Test Coverage For This Change

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@zalbiraw zalbiraw requested a review from a team as a code owner September 25, 2022 14:48
@zalbiraw zalbiraw requested review from komalsukhani and removed request for a team September 25, 2022 14:48
@komalsukhani
Copy link
Collaborator

@zalbiraw Don't we need it for Gateway service?

@zalbiraw
Copy link
Member Author

Yes @komalsukhani thats already in the templates actually. So we did it initially for the gateway but not the mdcb or dashboard l.

@caroltyk caroltyk changed the title Add ability to manage annotations for the MDCB and Dashboard services TT-7029 Add ability to manage annotations for the MDCB and Dashboard services Nov 8, 2022
@singhpr singhpr merged commit d7dfc4a into master Nov 11, 2022
@zalbiraw zalbiraw deleted the add-annotations branch November 28, 2022 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants