TT-7028 Fix support for bool values #242
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently if we try to set an extraEnv that is a bool variable the helm charts will fail...
failed to create resource: Deployment in version "v1" cannot be handled as a Deployment: json: cannot unmarshal bool into Go struct field EnvVar.spec.template.spec.containers.env.value of type string
Motivation and Context
Such sets will fail...
--set "mdcb.extraEnvs[0].name=TYK_MDCB_SYNCWORKER_ENABLED"
--set "mdcb.extraEnvs[0].value=true"
--set "mdcb.extraEnvs[1].name=TYK_MDCB_SYNCWORKER_HASHKEYS"
--set "mdcb.extraEnvs[1].value=true" \
Screenshots (if appropriate)
Types of changes
Checklist
master
!master
branch (left side). Also, it would be best if you started your change off our latestmaster
.