Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TT-7028 Fix support for bool values #242

Merged
merged 1 commit into from
Nov 11, 2022
Merged

TT-7028 Fix support for bool values #242

merged 1 commit into from
Nov 11, 2022

Conversation

zalbiraw
Copy link
Member

@zalbiraw zalbiraw commented Nov 1, 2022

Description

Currently if we try to set an extraEnv that is a bool variable the helm charts will fail...

failed to create resource: Deployment in version "v1" cannot be handled as a Deployment: json: cannot unmarshal bool into Go struct field EnvVar.spec.template.spec.containers.env.value of type string

Motivation and Context

Such sets will fail...
--set "mdcb.extraEnvs[0].name=TYK_MDCB_SYNCWORKER_ENABLED"
--set "mdcb.extraEnvs[0].value=true"
--set "mdcb.extraEnvs[1].name=TYK_MDCB_SYNCWORKER_HASHKEYS"
--set "mdcb.extraEnvs[1].value=true" \

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@zalbiraw zalbiraw requested a review from a team as a code owner November 1, 2022 17:59
@zalbiraw zalbiraw requested review from andrei-tyk and removed request for a team November 1, 2022 17:59
@caroltyk caroltyk changed the title Fix support for bool values TT-7027 Fix support for bool values Nov 8, 2022
@caroltyk caroltyk changed the title TT-7027 Fix support for bool values TT-7028 Fix support for bool values Nov 8, 2022
@singhpr singhpr merged commit 90456ba into master Nov 11, 2022
@zalbiraw zalbiraw deleted the fix-extraEnvs-bools branch November 28, 2022 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants