-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TT-7211] Fix headless templates #250
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great considering the current problem that we faced.
We also use .Values.mongo
and .Values.redis
in different places, for instance in tyk-headless/gw-deployment
. Should we add nil check to these as you did in the helpers
? Or is it enough to add it to helpers
?
Sorry I missed those cases. Will fix them |
Description
Validate
redis
andmongo
fields are not nil before accessing it's child fieldsRelated Issue
TT-7211
Motivation and Context
Test Coverage For This Change
Installation was successful with empty
mongo
andredis
fields.Screenshots (if appropriate)
Types of changesmpaty m
Checklist
master
!master
branch (left side). Also, it would be best if you started your change off our latestmaster
.