Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TT-7211] Fix headless templates #250

Merged
merged 9 commits into from
Dec 1, 2022
Merged

Conversation

komalsukhani
Copy link
Collaborator

Description

Validate redis and mongo fields are not nil before accessing it's child fields

Related Issue

TT-7211

Motivation and Context

Test Coverage For This Change

Installation was successful with empty mongo and redis fields.

Screenshots (if appropriate)

Types of changesmpaty m

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@komalsukhani komalsukhani requested a review from a team as a code owner November 30, 2022 06:28
@komalsukhani komalsukhani requested review from andrei-tyk and removed request for a team November 30, 2022 06:28
Copy link
Member

@buraksekili buraksekili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great considering the current problem that we faced.
We also use .Values.mongo and .Values.redis in different places, for instance in tyk-headless/gw-deployment. Should we add nil check to these as you did in the helpers? Or is it enough to add it to helpers?

@komalsukhani
Copy link
Collaborator Author

It looks great considering the current problem that we faced. We also use .Values.mongo and .Values.redis in different places, for instance in tyk-headless/gw-deployment. Should we add nil check to these as you did in the helpers? Or is it enough to add it to helpers?

Sorry I missed those cases. Will fix them

@singhpr singhpr merged commit f65bc4f into master Dec 1, 2022
@zalbiraw zalbiraw deleted the TT-7211/fix_headless_templates branch March 23, 2023 13:44
@zalbiraw zalbiraw restored the TT-7211/fix_headless_templates branch March 23, 2023 13:44
@zalbiraw zalbiraw deleted the TT-7211/fix_headless_templates branch March 23, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants