Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TT-7255] Enable allow_explicit_policy_id for hybrid #251

Merged
merged 4 commits into from
Dec 16, 2022
Merged

[TT-7255] Enable allow_explicit_policy_id for hybrid #251

merged 4 commits into from
Dec 16, 2022

Conversation

komalsukhani
Copy link
Collaborator

Description

Enable allow_explicit_policy_id for hybrid by default

Related Issue

Motivation and Context

This flag is required if user is using operator with hybrid charts.

Test Coverage For This Change

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@komalsukhani komalsukhani requested a review from a team as a code owner December 5, 2022 06:23
@komalsukhani komalsukhani requested review from andrei-tyk and removed request for a team December 5, 2022 06:23
@komalsukhani komalsukhani changed the title Change default settings Change default settings of hybrid chart Dec 5, 2022
@komalsukhani komalsukhani changed the title Change default settings of hybrid chart [TT-7255] Enable allow_explicit_policy_id for hybrid Dec 6, 2022
@singhpr singhpr merged commit cd773f3 into master Dec 16, 2022
totogo pushed a commit to Rubyx-IO/tyk-helm-chart that referenced this pull request Jan 27, 2023
@komalsukhani @totogo
[TT-7255] Enable allow_explicit_policy_id for hybrid (TykTechnologies…
68a7d04 
…#251)

* Set `allow_explicit_policy_id` to true

* Update changelog
@zalbiraw zalbiraw deleted the change_default_settings branch March 23, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buraksekili buraksekili buraksekili approved these changes

@andrei-tyk andrei-tyk Awaiting requested review from andrei-tyk andrei-tyk is a code owner automatically assigned from TykTechnologies/operator-squad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@komalsukhani @buraksekili @singhpr