Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal tib - Ability to receive custom super-dashboard-dispatcher #120

Merged

Conversation

sredxny
Copy link
Contributor

@sredxny sredxny commented Jul 30, 2020

Description

For embeded TIB is required to pass as well a request dispatcher for admin dashboard api, this api is consumed when the request fail to the standard api. Also handled the error throwed when is attempted to build a request without all the required parameters, in this way it will not panic.

Related Issue

Motivation and Context

Give solution to:

How This Has Been Tested

  • In testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If pulling from your own
    fork, don't request your master!
  • Make sure you are making a pull request against the master branch (left side). Also, you should start
    your branch off our latest master.
  • My change requires a change to the documentation.
    • If you've changed APIs, describe what needs to be updated in the documentation.
    • If new config option added, ensure that it can be set via ENV variable
  • I have updated the documentation accordingly.
  • Modules and vendor dependencies have been updated; run go mod tidy && go mod vendor
  • When updating library version must provide reason/explanation for this update.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Check your code additions will not fail linting checks:
    • go fmt -s
    • go vet

@matiasinsaurralde matiasinsaurralde merged commit 3d24df1 into master Aug 7, 2020
@jlucktay jlucktay deleted the ability-t-receive-custom-super-dashboard-dispatch branch January 12, 2021 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants