Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TT-6486/TT-9052] use Tyk CertificateManager interface #296

Merged
merged 1 commit into from
May 31, 2023

Conversation

jeffy-mathew
Copy link
Contributor

@jeffy-mathew jeffy-mathew commented May 30, 2023

Description

Related Issue

https://tyktech.atlassian.net/browse/TT-6486
TykTechnologies/tyk#5062 - adds an interface for certificate manager, this breaks tests in tyk-dashbord by importing tyk-identity-broker

Motivation and Context

How This Has Been Tested

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If pulling from your own
    fork, don't request your master!
  • Make sure you are making a pull request against the master branch (left side). Also, you should start
    your branch off our latest master.
  • My change requires a change to the documentation.
    • If you've changed APIs, describe what needs to be updated in the documentation.
    • If new config option added, ensure that it can be set via ENV variable
  • I have updated the documentation accordingly.
  • Modules and vendor dependencies have been updated; run go mod tidy && go mod vendor
  • When updating library version must provide reason/explanation for this update.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Check your code additions will not fail linting checks:
    • go fmt -s
    • go vet

@sonarcloud
Copy link

sonarcloud bot commented May 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jeffy-mathew jeffy-mathew requested a review from sredxny May 30, 2023 15:39
@sredxny
Copy link
Contributor

sredxny commented May 30, 2023

@jeffy-mathew please fill the "Related Issue" section so we have track of what was included. Also release it to release-1.4

@jeffy-mathew jeffy-mathew merged commit a6beb24 into master May 31, 2023
10 checks passed
@jeffy-mathew jeffy-mathew deleted the fix/tyk-certificate-manager-interface branch May 31, 2023 05:05
@jeffy-mathew
Copy link
Contributor Author

/release to release-1.4

@tykbot
Copy link

tykbot bot commented May 31, 2023

Working on it! Note that it can take a few minutes.

tykbot bot pushed a commit that referenced this pull request May 31, 2023
use CertificateManager interface from gateway

(cherry picked from commit a6beb24)
@tykbot
Copy link

tykbot bot commented May 31, 2023

@jeffy-mathew Succesfully merged PR

buger added a commit that referenced this pull request May 31, 2023
certificateManager interface (#296)

use CertificateManager interface from gateway
@jeffy-mathew jeffy-mathew changed the title use Tyk CertificateManager interface [TT-6486/TT-9052] use Tyk CertificateManager interface May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants